Add support of Ticket Field Options API in SDK #368
Conversation
| */ | ||
| public function update($id = null, array $updateResourceFields = []) | ||
| { | ||
| print_r($id); |
There was a problem hiding this comment.
Please remove debug code.
There was a problem hiding this comment.
Thanks @joseconsador the modifications has been performed. Does it fine for you?
|
@cmourizard is there any reason you override find, create, update etc.? |
|
Hi @jmramos02 it's because the route is a specific subroute of endpoint with some specific argument by example:
|
| { | ||
| $this->addTicketFieldIdToRouteParams($params); | ||
|
|
||
| $response = Http::send( |
There was a problem hiding this comment.
Looks like doing return $this->traitCreate($params); should be sufficient here? From the docs, the create method looks similar to other resources. update on the other hand, is indeed different.
|
|
||
| $this->addTicketFieldIdToRouteParams($updateResourceFields); | ||
|
|
||
| $response = Http::send( |
There was a problem hiding this comment.
Using $this->client->post method in client looks like it can be used directly here. It's a only small abstraction though but might as well.
| findAll as traitFindAll; | ||
| find as traitFind; | ||
| create as traitCreate; | ||
| update as traitUpdate; |
There was a problem hiding this comment.
Can probably be removed if the default update method will not be used?
Rewamp calls to API
|
Hello @joseconsador and @miogalang all modifications has been performed I let you review them. |
|
Sounds great @samgavinio thanks! Do you have an estimated date of merge @joseconsador? |
|
@cmourizard released as v2.2.4. Thanks! |
…dTicketFieldOptionsSupport Add support of Ticket Field Options API in SDK
Add support of Ticket Field Options API in SDK (https://developer.zendesk.com/rest_api/docs/core/ticket_fields#list-ticket-field-options)