Fix sell contacts test by url encoding query params for assertion

zendesk · Sep 24, 2024 · 4a2ee60 · 4a2ee60
1 parent 1184245
commit 4a2ee60
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/tests/Zendesk/API/UnitTests/Sell/ContactsTest.php b/tests/Zendesk/API/UnitTests/Sell/ContactsTest.php
@@ -40,10 +40,20 @@ public function testUpsert()
             ]
         ];
 
+        $encodedQueryParams = [];
+        foreach ($queryParams as $key => $value) {
+            // Don't encode the email address
+            if ($key === 'email') {
+                $encodedQueryParams[$key] = $value;
+                continue;
+            }
+            $encodedQueryParams[$key] = rawurlencode($value);
+        }
+
         $this->assertEndpointCalled(function () use ($queryParams, $postFields) {
             $this->client->sell->contacts()->upsert($queryParams, $postFields);
         }, '/contacts/upsert', 'POST', [
-            'queryParams' => $queryParams,
+            'queryParams' => $encodedQueryParams,
             'postFields'  => ['data' => $postFields],
             'apiBasePath' => '/v2'
         ]);