Merge pull request #35 from zendesk/invalid-owner

Invalid owner
zendesk · Jan 17, 2024 · 88c509e · 88c509e
2 parents ac30926 + 6236a0e
commit 88c509e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/bin/check-codeowners b/bin/check-codeowners
diff --git a/spec/checking_mode_spec.rb b/spec/checking_mode_spec.rb
@@ -167,7 +167,7 @@
 
         aggregate_failures do
           expect(r.status.exitstatus).to eq(1)
-          expect(r.stdout).to eq("ERROR: Invalid owner @org/team1 at .github/CODEOWNERS:1\n" + help_message)
+          expect(r.stdout).to eq("ERROR: Invalid owner @org/team1 at .github/CODEOWNERS:1, not present in .github/VALIDOWNERS\n" + help_message)
           expect(r.stderr).to eq("")
         end
       end

diff --git a/src/lib/check_codeowners/checks.rb b/src/lib/check_codeowners/checks.rb
@@ -66,7 +66,7 @@ def check_valid_owners
           bad_owners.each do |bad_owner|
             errors << {
               code: "invalid_owner",
-              message: "Invalid owner #{bad_owner} at #{entry.file}:#{entry.line_number}",
+              message: "Invalid owner #{bad_owner} at #{entry.file}:#{entry.line_number}, not present in .github/VALIDOWNERS",
               bad_owner: bad_owner,
               entry: entry
             }