-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a case when v1/action/query
returns only InternalServerError
#107
Conversation
…r the queries with excluded fields
Thanks for the review @jurisgalang The run output after last commit is:
|
@jurisgalang I deployed the custom branch in this https://github.com/zendesk/billing/pull/16354 to billing 999 and verified export tasks works: The result of first run of export tasks: https://github.com/zendesk/billing/pull/16356, also verified inside ric 999 |
Fix a case when
v1/action/query
returns only InternalServerError for the queries with excluded fieldsDescription
Currently we are unable to do Zuora Catalog Export due to
IronBank::Schema.excluded_fields
throws an error each time. It could be depended to the latest Zuora Release and it blocks our work for other billing projects.Please checkout this branch, go into
bin/console
and runIronBank::Schema.excluded_fields.sort.to_h
( same command billing rake task does ).The expected output is:
Notes
InternalServerError
does not contain any information inside about failed fields.Recursively dividing field list by two ranges each time until the failing field is not got.
References
Risks
Low. This extends the
IronBank::Describe::ExcludedFields
service capability to handle situations where the response from Zuora does not list the unqueryable fields without changing the original strategy (but at the cost of performance)