Bump nokogiri to v1.17.2 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjrobertson
force-pushed
the
danr/update-nokogiri
branch
from
08e1966 to
fbe6d34
Compare
- adds an `encoding` param since nokogiri v1.17 attempts to autodetect the document encoding. This autodetection caused some tests to fail when other languages were used - early returns when the source is an empty string as this now throws an error in nokogiri v1.17+
danjrobertson
force-pushed
the
danr/update-nokogiri
branch
from
fbe6d34 to
e40d3df
Compare
alduethadyn
approved these changes
Jan 23, 2025
alduethadyn
reviewed
Jan 23, 2025
|
We will need to merge and bump this before we can proceed with the zendesk_mtc_mpq_migration bump |
danjrobertson
force-pushed
the
danr/update-nokogiri
branch
from
6ec1536 to
e40d3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the nokogiri gem to v1.17.2. This is required to unblock the same nokogiri update in other gems and apps that rely on abbreviato.
This PR also adds an
encodingparam since nokogiri v1.17 attempts to autodetect the document encoding. This autodetection caused some tests to fail when other languages were used. It also adds an early return when the source is an empty string as this now throws an error in nokogiri v1.17+The v1.17.0+ of nokogiri allows XML ints to be greater than 24 digits which is required to resolve a Z2 ticket