refactor: update window focus logic for consistency #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `SystemWindowRelativeFocus*` to use `systemWindows` for sorting and filtering. Ensure all window comparisons are done using the nested `window.rect` properties. Add additional checks in loops for better accuracy in determining next window. This enhances consistency and accuracy in window navigation.
Update SystemWindowRelativeFocus methods to return `currentWindow` instead of `nil`. This ensures that the current window is correctly returned when the focus shift functions are called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
SystemWindowRelativeFocus*to usesystemWindowsfor sortingand filtering. Ensure all window comparisons are done using the nested
window.rectproperties. Add additional checks in loops for betteraccuracy in determining next window. This enhances consistency and
accuracy in window navigation.