Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify window focus logic and streamline call #540

Merged
merged 1 commit into from
Jun 5, 2024
Merged

simplify window focus logic and streamline call #540

merged 1 commit into from
Jun 5, 2024

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Jun 5, 2024

Remove inout parameter in SystemFrontmostWindowFocus.run, assign frontMostIndex within the function, and streamline call in SystemCommandRunner for better maintainability.

@zenangst
```
3555d3f 
refactor: simplify window focus logic and streamline call

Remove inout parameter in SystemFrontmostWindowFocus.run,
assign frontMostIndex within the function, and streamline
call in SystemCommandRunner for better maintainability.
```
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Test: succeeded ✅
https://github.com/zenangst/KeyboardCowboy/actions/runs/9391447912

@zenangst

@zenangst zenangst merged commit 6e9bc10 into main Jun 5, 2024
2 checks passed
@zenangst zenangst deleted the remove-frontmostindex-from-run-function branch June 5, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymmarkov vadymmarkov Awaiting requested review from vadymmarkov vadymmarkov is a code owner

@pkrll pkrll Awaiting requested review from pkrll pkrll is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zenangst