Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various performance optimizations #310

Merged
merged 5 commits into from
Jun 22, 2023

Add missing returns

75434a7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Various performance optimizations #310

Add missing returns
75434a7
Select commit
Loading
Failed to load commit list.
GitHub Actions / Xcode test results succeeded Jun 22, 2023 in 0s

Xcode test results

Testing workspace Keyboard Cowboy with scheme Keyboard-Cowboy

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
23230000.07s

Test Summary

UnitTests

  • Device: Mac mini, 13.4 (22F66)
  • SDK: macOS 13.3, 13.3
TestTotalSuccessFailureSkippedExpected Failure
test-class ApplicationTriggerControllerTests33000
test-class ContentViewActionReducerTests55000
test-class DropCommandsControllerTests55000
test-class KeyShortcutTests99000
test-class KeyboardShortcutsControllerTests11000

Failure Failures

All tests passed 🎉

Code Coverage

Coverage Covered Executable
Keyboard Cowboy.app 5.43 % 1481 27297
  MenuBarCommand.swift 0.00 % 0 25
  AutoCompletionView.swift 0.00 % 0 79
  NewCommandWindow.swift 19.42 % 40 206
  SidebarLabelStyle.swift 0.00 % 0 8
  AppUpdater.swift 40.00 % 4 10
  LargeTextFieldStyle.swift 0.00 % 0 21
  ApplicationCommandView.swift 0.00 % 0 248
  ContentHeaderView.swift 0.00 % 0 165
  NewCommandScriptView.swift 0.00 % 0 325
  AppMenuStyle.swift 0.00 % 0 37
  DesignTimePublishers.swift 1.58 % 3 190
  MoveManager.swift 0.00 % 0 22
  NewCommandMenuBarView.swift 0.00 % 0 658
  GroupSymbol.swift 0.00 % 0 212
  Command+Name.swift 0.00 % 0 68
  InsertionView.swift 0.00 % 0 25
  TypeEngine.swift 13.33 % 4 30
  NSEventController.swift 0.00 % 0 21
  OpenFolderInFinder.swift 20.83 % 5 24
  BaseSyntaxHighlighting.swift 0.00 % 0 76
  CommandContainerView.swift 0.00 % 0 615
  ContentListEmptyView.swift 0.00 % 0 143
  BezelNotificationCoordinator.swift 0.00 % 0 4
  OpenFilePlugin.swift 21.43 % 3 14
  Storage.swift 7.32 % 6 82
  NSColor+Extensions.swift 0.00 % 0 32
  SymbolPalette.swift 0.00 % 0 98
  WorkflowTriggerListView.swift 0.00 % 0 98
  PermissionsScene.swift 100.00 % 29 29
  ConfigurationStore.swift 5.00 % 3 60
  DetailModelMapper.swift 1.59 % 3 189
  SidebarCoordinator.swift 11.18 % 18 161
  FocusView.swift 0.00 % 0 94
  AppTextFieldStyle.swift 0.00 % 0 77
  BezelNotificationWindow.swift 0.00 % 0 29
  ScriptCommand.swift 13.33 % 6 45
  DetailCommandContainerActionReducer.swift 0.00 % 0 15
  SplashView.swift 0.00 % 0 204
  NewCommandValidation.swift 0.00 % 0 27
  GroupItemView.swift 0.00 % 0 106
  CommandKeyIcon.swift 0.00 % 0 110
  DetailViewActionReducer.swift 0.00 % 0 144
  ContentViewActionReducer.swift 96.97 % 32 33
  ShellScriptHighlighting.swift 0.00 % 0 48
  URLIcon.swift 0.00 % 0 98
  OpenPanelController.swift 0.00 % 0 35
  GradientButtonStyle.swift 0.00 % 0 150
  ContentView.swift 0.00 % 0 76
  ContentBackgroundView.swift 0.00 % 0 29
  KeyCodesStore.swift 16.67 % 7 42
  DebounceManager.swift 0.00 % 0 11
  ContentImagesView.swift 0.00 % 0 76
  DraggableView.swift 0.00 % 0 16
  DropCommandsController.swift 98.04 % 50 51
  ShortcutCommand.swift 0.00 % 0 19
  ColorPalette.swift 0.00 % 0 73
  KeyShortcut.swift 100.00 % 37 37
  Command.swift 7.24 % 16 221
  CommandSymbol.swift 0.00 % 0 134
  NotificationCoordinator.swift 0.00 % 0 35
  WorkflowCommandListView.swift 0.00 % 0 376
  FolderSymbol.swift 0.00 % 0 306
  TuistBundle+KeyboardCowboy.swift 0.00 % 0 3
  NewCommandShortcutView.swift 0.00 % 0 108
  DebounceSelectionManager.swift 0.00 % 0 16
  NewCommandApplicationView.swift 0.00 % 0 346
  FeatureIcon.swift 0.00 % 0 99
  OpenURLSwapTabsPlugin.swift 10.34 % 3 29
  AddButtonView.swift 0.00 % 0 110
  GroupsHeaderView.swift 0.00 % 0 22
  WorkflowTriggerView.swift 0.00 % 0 154
  TypingSymbol.swift 0.00 % 0 51
  NewCommandBuiltInView.swift 0.00 % 0 6
  NSFont+Extensions.swift 0.00 % 0 21
  EditableKeyboardShortcutsView.swift 0.00 % 0 710
  SidebarConfigurationHeaderView.swift 0.00 % 0 7
  NewCommandImageView.swift 0.00 % 0 78
  ApplicationStore.swift 43.90 % 18 41
  GroupBackgroundView.swift 0.00 % 0 24
  DetailCommandActionReducer.swift 0.00 % 0 236
  AutoCompletion.swift 0.00 % 0 83
  EditConfigurationView.swift 0.00 % 0 118
  WorkflowOuputView.swift 0.00 % 0 98
  OpenURLParser.swift 0.00 % 0 16
  FocusPublisher.swift 0.00 % 0 27
  KeyboardCowboyConfiguration.swift 4.52 % 8 177
  AutoCompletionStore.swift 0.00 % 0 5
  PermissionsView.swift 0.65 % 2 310
  MenuBarEngine.swift 1.85 % 1 54
  TuistAssets+KeyboardCowboy.swift 0.00 % 0 40
  KeyboardCowboy+Extensions.swift 45.45 % 10 22
  TypeCommandView.swift 0.00 % 0 123
  SidebarMapper.swift 0.00 % 0 25
  WorkflowApplicationTriggerView.swift 0.00 % 0 260
  CommandView.swift 0.00 % 0 274
  View+Extensions.swift 0.00 % 0 181
  KeyShortcutRecorderStore.swift 0.00 % 0 10
  FocusableProxy.swift 0.00 % 0 52
  WorkflowShortcutsView.swift 0.00 % 0 36
  NewCommandButtonView.swift 0.00 % 0 22
  StorageConfiguration.swift 57.14 % 4 7
  DropItem.swift 0.00 % 0 18
  ScriptEditorView.swift 0.00 % 0 52
  Rule.swift 0.00 % 0 13
  AppDelegate.swift 72.73 % 8 11
  SwiftSyntaxHighlighting.swift 0.00 % 0 23
  AppCheckbox.swift 0.00 % 0 200
  EditableKeyboardShortcutsItemView.swift 0.00 % 0 93
  LaunchApplicationPlugin.swift 18.75 % 3 16
  Workflow.swift 13.08 % 17 130
  AppStorageStore.swift 100.00 % 6 6
  DesignTime+Extensions.swift 0.00 % 0 11
  WindowListStore.swift 0.00 % 0 7
  CommandViewModel.swift 0.00 % 0 23
  WorkflowGroup.swift 19.35 % 12 62
  FeatureBetaModifier.swift 0.00 % 0 309
  ShortcutsEngine.swift 25.00 % 3 12
  NotificationListView.swift 0.00 % 0 109
  ContentCoordinator.swift 8.97 % 13 145
  ApplicationTriggerController.swift 97.50 % 117 120
  KeyboardView.swift 0.00 % 0 780
  AppleScriptPlugin.swift 7.08 % 15 212
  LineNumbersView.swift 0.00 % 0 73
  GeometryPreferenceKeyView.swift 0.00 % 0 9
  _ScriptEditorView.swift 0.00 % 0 183
  OpenEngine.swift 18.42 % 7 38
  ApplicationCommand.swift 18.42 % 7 38
  DetailEmptyView.swift 0.00 % 0 7
  DetailViewModel.swift 0.00 % 0 31
  Array+Extensions.swift 0.00 % 0 28
  FolderIcon.swift 0.00 % 0 285
  GroupsView.swift 0.00 % 0 58
  BuildInCommand.swift 0.00 % 0 34
  ShellScriptPlugin.swift 5.26 % 3 57
  MenubarIcon.swift 0.00 % 0 88
  NewSystemCommandView.swift 0.00 % 0 109
  Highlight.swift 0.00 % 0 4
  ScriptEngine.swift 30.43 % 7 23
  ShortcutStore.swift 7.84 % 4 51
  SystemCommandEngine.swift 3.21 % 10 312
  AppsIcon.swift 0.00 % 0 80
  NewCommandKeyboardShortcutView.swift 0.00 % 0 90
  IconView.swift 0.00 % 0 52
  Set+Extensions.swift 0.00 % 0 16
  SystemCommand.swift 0.00 % 0 36
  MissionControlPlugin.swift 9.38 % 3 32
  NewCommandOpenView.swift 0.00 % 0 259
  SelectionManager.swift 10.53 % 16 152
  ScriptEditorViewable.swift 0.00 % 0 40
  Application.swift 8.77 % 5 57
  EnterKey.swift 0.00 % 0 173
  AppEnvironment.swift 0.00 % 0 1
  URLSymbol.swift 0.00 % 0 68
  MultiDetailView.swift 0.00 % 0 415
  Draggable+Extensions.swift 0.00 % 0 12
  ContentModelMapper.swift 0.00 % 0 165
  ScriptSymbol.swift 0.00 % 0 77
  DetailView.swift 0.00 % 0 68
  KeyboardCommandView.swift 0.00 % 0 139
  RegularKeyIcon.swift 0.00 % 0 207
  KeyboardEngine.swift 5.45 % 3 55
  WorkflowApplicationTriggerItemView.swift 0.00 % 0 243
  UnknownView.swift 0.00 % 0 61
  HeaderLabelStyle.swift 0.00 % 0 8
  OpenCommandView.swift 0.00 % 0 224
  TypeCommand.swift 40.00 % 6 15
  SidebarConfigurationView.swift 0.00 % 0 453
  WorkflowCommandEmptyListView.swift 0.00 % 0 125
  ContentImageView.swift 0.00 % 0 140
  Letter.swift 0.00 % 0 1
  Injection+Extensions.swift 53.33 % 8 15
  AppButtonStyle.swift 0.00 % 0 56
  AppSymbol.swift 0.00 % 0 168
  AppMenuBar.swift 72.17 % 83 115
  Encodable+Extensions.swift 0.00 % 0 14
  TogglesView.swift 0.00 % 0 76
  NotificationWindow.swift 0.00 % 0 32
  ContentViewModel.swift 0.00 % 0 17
  KeyboardShortcutTrigger.swift 100.00 % 4 4
  KeyboardCowboy.swift 61.71 % 311 504
  KeyboardShortcutsController.swift 96.43 % 135 140
  EditWorfklowGroupWindow.swift 33.75 % 27 80
  GroupIconView.swift 0.00 % 0 56
  ContentListView.swift 0.00 % 0 597
  

Details

Test Details

UnitTestsback

ApplicationTriggerControllerTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testApplicationTriggerController_closed()
Successtest-method testApplicationTriggerController_frontMost()
Successtest-method testApplicationTriggerController_launched()

ContentViewActionReducerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testReduceContentViewAction_addWorkflow()
Successtest-method testReduceContentViewAction_moveWorkflows()
Successtest-method testReduceContentViewAction_moveWorkflowsToGroup()
Successtest-method testReduceContentViewAction_noop()
Successtest-method testReduceContentViewAction_removeWorflows()

DropCommandsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testGeneratingAppleScriptCommand()
Successtest-method testGeneratingApplicationCommand()
Successtest-method testGeneratingFileCommand()
Successtest-method testGeneratingShellScriptCommand()
Successtest-method testGeneratingWebCommand()

KeyShortcutTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testEmptyMethod()
Successtest-method testFromDecoder_ID_Key_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifier_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifiers_Data()
Successtest-method testFromDecoder_Key_Data()
Successtest-method testModifersDisplayValue()
Successtest-method testStringValue()
Successtest-method testValidationValue()

KeyboardShortcutsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.07s
Successtest-method testLookupInLargeCollection()
View more details on GitHub Actions