Update theme: Bigger Mute Button #975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jvabn
commented
Jan 31, 2025
jvabn
commented
- Removed list-style-image; reworked compact tabs audio icon display
- List style image results in a black overlay over the mute button since a more recent Zen update. Tried a workaround with mask to get this to be transparent, but could not get it to work as intended.
- Reworked the way the audio icon is displayed when tabs are compact so that it now properly hides the favicon. This also fixed an issue occurring when audio was playing from a pinned tab.
- New theme image reflects changes to icon image in latest theme version.
List style image results in a black overlay over the mute button since a more recent Zen update. Tried a workaround with mask to get this to be transparent, but could not get it to work as intended. Reworked the way the audio icon is displayed when tabs are compact so that it now properly hides the favicon. This also fixed an issue occurring when audio was playing from a pinned tab.
mauro-balades
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Please remove this image or at least make it the same size
|
@mauro-balades Sorry about the image size. Does the newly added image here work ok? Height is the same as the original image, though width is a little larger. Let me know if there are specific dimensions you would prefer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.