Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for transforms #431

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Add support for transforms #431

merged 2 commits into from
Oct 18, 2019

Conversation

juanjoDiaz
Copy link
Collaborator

Closes #406

Pretty major change.

Add support for transforms on the data.
Unwind and flatten are now 2 examples of such transforms.

@juanjoDiaz juanjoDiaz added this to the v5 milestone Oct 15, 2019
@coveralls
Copy link

coveralls commented Oct 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 34557a7 on juanjoDiaz:add_support_for_transforms into f7dd7eb on zemirco:master.

knownasilya
knownasilya requested changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good implementation wise, the only thing missing is docs for this new feature.

knownasilya
knownasilya reviewed Oct 18, 2019
View reviewed changes
README.md Show resolved Hide resolved
@knownasilya knownasilya merged commit f1d04d0 into zemirco:master Oct 18, 2019
@juanjoDiaz juanjoDiaz deleted the add_support_for_transforms branch November 9, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.

Add transform option
3 participants
@juanjoDiaz @coveralls @knownasilya