Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the flattening separator feature #315

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Clean up the flattening separator feature #315

merged 1 commit into from
Aug 1, 2018

Conversation

juanjoDiaz
Copy link
Collaborator

Clean up a bit after #314.

  • Improves function signature bringing it back to the original approach.
  • Add missing tests.
  • Fix a typo in the old tests names.

Also, next time we merge a change that modifies the functions signatures, please create a task so I update the TypeScript types.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b325788 on juanjoDiaz:flattening_separator_cleanup into 24d7654 on zemirco:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b325788 on juanjoDiaz:flattening_separator_cleanup into 24d7654 on zemirco:master.

@coveralls
Copy link

coveralls commented Aug 1, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b325788 on juanjoDiaz:flattening_separator_cleanup into 24d7654 on zemirco:master.

@knownasilya
Copy link
Collaborator

Good point about the types. Want to rewrite this in TS so we have types automatically? 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants