New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid throwing an error on elements that can't be stringified #223

Merged

knownasilya merged 1 commit into zemirco:master from juanjoDiaz:bugfix/json_containing_functions

Jan 21, 2018

Collaborator

juanjoDiaz commented Jan 21, 2018

Closes #215

Some elements can't be stringified. For example functions (JSON.stringify(() => {}) results on undefined).

We didn't handle those case, so json objects with non-stringifiable fields threw an error (not even related to the serialization).

This PR fixes that and add a test to cover this case.


          Avoid throwing an error on elements that can't be stringified (like f…

3a1188f

…unctions)

coveralls commented Jan 21, 2018 •

edited

Loading

Coverage remained the same at 100.0% when pulling 3a1188f on juanjoDiaz:bugfix/json_containing_functions into 7f7338f on zemirco:master.

knownasilya merged commit 679c687 into zemirco:master

juanjoDiaz deleted the bugfix/json_containing_functions branch

February 4, 2018 22:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet