perf: do quote replacement in a single pass

zemirco · Jan 27, 2021 · 5f001b7 · 5f001b7
1 parent e1c8be1
commit 5f001b7
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/JSON2CSVBase.js b/lib/JSON2CSVBase.js
@@ -168,13 +168,15 @@ class JSON2CSVBase {
     }
 
     if (typeof value === 'string') {
-      if(value.includes(this.opts.quote)) {
-        value = value.replace(new RegExp(this.opts.quote, 'g'), this.opts.escapedQuote);
-      }
-
       if (this.opts.excelStrings) {
-        value = `"=""${value.replace(new RegExp(this.opts.quote, 'g'), this.opts.escapedQuote)}"""`;
+        if(value.includes(this.opts.quote)) {
+          value = value.replace(new RegExp(this.opts.quote, 'g'), `${this.opts.escapedQuote}${this.opts.escapedQuote}`);
+        }
+        value = `"=""${value}"""`;
       } else {
+        if(value.includes(this.opts.quote)) {
+          value = value.replace(new RegExp(this.opts.quote, 'g'), this.opts.escapedQuote);
+        }
         value = `${this.opts.quote}${value}${this.opts.quote}`;
       }
     }