Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some typos in sanitizeCore.php #4

Closed
robre opened this issue Feb 11, 2020 · 1 comment
Closed

Some typos in sanitizeCore.php #4

robre opened this issue Feb 11, 2020 · 1 comment
Assignees
@zelon88
Labels
Bug Something isn't working

Comments

@robre
Copy link

robre commented Feb 11, 2020

I noticed that there are some typos in sanitizeCore.php - I am too lazy to create a pull request.
line 96 - 'sstr_replace' and 'tr_replace' are used instead of 'str_replace'
also I suspect in line 95 maybe you meant filestodownload instead of upload?

best regards
zelon88 added a commit that referenced this issue Feb 12, 2020
@zelon88
v2.6 - Improve sanitization per Issue #4
8e67e32 
-v2.6.
-Improve sanitization per Issue #4.
-Github user @robre pointed out some typos in sanitizeCore.php, specifically lines 95 & line 96 from v2.4.
-These bugs mean to me that I need to review more of this code.
-Thank you, @robre!
@zelon88
Copy link
Owner

zelon88 commented Feb 12, 2020 •
edited
Loading

You are absolutely correct! I'm sorry for these mistakes and I appreciate you bringing my attention to them. I am away from my desk at the moment, but I've fixed the code in question in commit 8e67e32. Specifically lines 95 & 96 of sanitizeCore.php. I will make time in the very near future to do a thorough review of this code. Thanks again.

Because you took the time to report an issue (and a very concise correction for it), and in accordance with the HonestRepair Alternative Licensing Policy; please enjoy a BSD 3-Clause License for HRConvert2 for life. Thanks for contributing to HonestRepair open-source software!

I'll leave this issue open for a couple days as a reference for other users.

@zelon88 zelon88 closed this as completed Feb 21, 2020
@zelon88 zelon88 self-assigned this Jun 10, 2024
@zelon88 zelon88 added the Bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zelon88 zelon88

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robre @zelon88