Colliders: colType -> colMaterial #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fig02
approved these changes
Sep 11, 2024
krm01
approved these changes
Sep 11, 2024
|
type as its currently called is far too broad. that could mean anything: shape? (cylinder/sphere/tri etc) function? (ac/at/ot) |
|
Yeah "type" makes this sound too important when it's just graphical changes |
cadmic
approved these changes
Sep 11, 2024
|
more than graphical right cause audio too, but yeah point is still the same |
|
Yeah there's also one place (afaik only one) where it changes sfx, but most sfx changes are handled by the elem materials (currently types) afaict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1925
Rename
Collider.colType/COLTYPE_->Collider.colMaterial/COL_MATERIAL_