audio_seqplayer.c cleanup #1274
Conversation
#1248 focuses on the sequence instructions themselves, both the instruction names and as a base to think about how to document the instructions through either macros or comments This PR focuses on the code and the various functions, and cleans up temps, spacing, minor docs, etc. |
| AudioSeq_SeqLayerProcessScriptStep5(layer, val); | ||
|
|
||
| if (cmd != -1) { | ||
| AudioSeq_SeqLayerProcessScriptStep5(layer, cmd); |
There was a problem hiding this comment.
cmd is sameSound at this point, may be worth a comment if the variable is changed to cmd
(also that -1 could be a define maybe like PROCESS_SCRIPT_CONTINUE idk 🤷)
There was a problem hiding this comment.
Oh, that is weird that AudioSeq_SeqLayerProcessScriptStep4 returns sameSound (sameTunedSample) instead of a command. Yeah, defs worth a comment.
I wonder if that define should be for the "layer" interpreter, or kept to a more "general" interpreter for "sequences" and "channels" two, since there are basically 3 different languages in here. I'll look into it. Either way, the name should reflect which of the scripts it's for
* Audio Seqplayer Cleanup * More * Edit description * PR Suggestions * while true * Cleanup function declarations * Extra space, oops * Small fix * PR Suggestions * tatums per beat * Edit comment
More cleanup for the file that runs and interprets sequence instructions for the .seq files