audio_seqplayer.c OK and partial docs #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isghj5
reviewed
May 31, 2022
|
I'll be drafting this until PlayState is renamed #835 |
|
This PR is updated and ready for review again |
EllipticEllipsis
approved these changes
Jul 10, 2022
hensldm
approved these changes
Jul 14, 2022
Kenix3
suggested changes
Jul 17, 2022
Kenix3
approved these changes
Jul 18, 2022
Kenix3
added
Merge-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next audio PR, this time focused on sequences! This file contains the interpreter for the scripting language used in writing sequences. These sequence instructions aren't fully documented as there are still many unknowns in audio, and I haven't introduced enums for the seq instructions yet as I want to coordinate that with OoT first.