Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of cmds to slashcommands #294

Merged
merged 9 commits into from
Oct 6, 2021
Merged

Conversation

awsdcrafting
Copy link
Contributor

@awsdcrafting awsdcrafting commented Oct 6, 2021

The commands

  • Ban
  • Bug
  • Clear

are ported to the new slashcommand system.
It is pretty much a 1-to-1 port. (E.g. most code is copied from the old versions).

Also fixed a bug, that the bot would crash if no twitchnotifier were used.

part of #290

If no twitch id / secret was provided the twitchnotifier init script would return a nil pointer. The timer would then try to call the Handle function of this (nil) pointer.
If no twitch id / secret was provided the twitchnotifier init script would return a nil pointer. The timer would then try to call the Handle function of this (nil) pointer.
Discord showed a message, that the ban interaction failed, although it successfully banned. Add Defer statement to show that a response will later be available
Add the slashcommand port of the bug command.
Add Clear slash command
Clear command was deleting 1 message less than expected.
Interactions were wrongly marked as failed, because no follup message was sent.
@zekroTJA
Copy link
Owner

zekroTJA commented Oct 6, 2021

Sadly, I already ported the ban command and merged it with the kick and report command into one single slash command, so I guess, I will remove it and keep the other changes.

Thank you really much for your effort though.

The next commands I want to port are the following:

  • mute
  • perms
  • chanstats
  • exec
  • say

Just to avoid the possibility of further collisions. ^^

@zekroTJA zekroTJA merged commit 3ac8ed3 into zekroTJA:dev Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants