-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstraction of the base asset #629
Conversation
In the runtime the only occurrence of the I would assume, that the correct abstraction of the base asset is to use the But there is a problem, that the new |
At the moment I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 👍
I guess the next step is to add a base_asset
field to the Market
primitive and replace ZTG with the market's base_asset
where appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, thanks for paving the way to using other chains assets within the prediction markets. Can't await the moment when the first external token enters a market!
/// Slash | ||
type Slash: OnUnbalanced<NegativeImbalanceOf<Self>>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with that, we'll handle treasury deposits a bit later down the line.
I'll have a look and approve eventually after overflow handling was applied and main was merge into this. |
Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
Related to #100.
The aim is to use only the
MultiCurrency
trait for the prediction market pallet instead of directly calling the balances pallet.Therefore it's easier to use a different base asset (like aUSD) later.