conf: Add sphinx_rtd_theme to extensions, remove env based import #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelzel
force-pushed
the
topic/awelzel/wrangling-html-theme
branch
from
150f066
to
c267e69
Compare
|
Something must have changed on the RTD side - I've ended up here which is from a few days ago: The build above succeeded, so I think this still makes sense. |
bbannier
approved these changes
Aug 24, 2023
The RTD build failed with "NameError: name 'html_theme' is notdefined". Remove the conditional import and align to what Spicy and the sphinx_rtd_theme docs [1] indicate should be done. [1] https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html
awelzel
force-pushed
the
topic/awelzel/wrangling-html-theme
branch
from
c267e69
to
11b3148
Compare
awelzel
added a commit
to zeek/broker
that referenced
this pull request
Aug 28, 2023
Zeek side reference: zeek/zeek-docs#206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTD build failed with "NameError: name 'html_theme' is not defined".
Remove the conditional import and align to what Spicy and the sphinx_rtd_theme docs [1] indicate should be done.
[1] https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html
RTD build: https://readthedocs.org/projects/zeek-docs/builds/21704944/