Add the requirement that all bookmarks require distinct translations

zeeguu · Oct 24, 2024 · 24a8dd1 · 24a8dd1
1 parent aba0e8f
commit 24a8dd1
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/exercises/assignBookmarksToExercises.js b/src/exercises/assignBookmarksToExercises.js
@@ -81,6 +81,14 @@ function assignBookmarksWithLearningCycle(bookmarks, exerciseTypesList) {
     return distinctContextsCount === potentialBookmarkContexts.length;
   }
 
+  function _distinctTranslations(potentialBookmarks) {
+    let potentialBookmarkContexts = potentialBookmarks.map(
+      (bookmark) => bookmark.to,
+    );
+    let distinctContextsCount = new Set(potentialBookmarkContexts).size;
+    return distinctContextsCount === potentialBookmarkContexts.length;
+  }
+
   let exerciseSequence = [];
 
   let exercisesByCycleTask = getElementsByCycleTask(
@@ -109,7 +117,12 @@ function assignBookmarksWithLearningCycle(bookmarks, exerciseTypesList) {
           let availableBookmarks = currentBookmarkList.length;
           if (
             requiredBookmarks <= availableBookmarks &&
-            _distinctContexts(currentBookmarkList.slice(0, requiredBookmarks))
+            _distinctContexts(
+              currentBookmarkList.slice(0, requiredBookmarks),
+            ) &&
+            _distinctTranslations(
+              currentBookmarkList.slice(0, requiredBookmarks),
+            )
           ) {
             let testedBookmarks = popNElementsFromList(
               currentBookmarkList,