Refactoring the refactoring #10
Conversation
| from datetime import datetime | ||
|
|
||
| from python_translators.translators.glosbe_translator import Translator | ||
| from python_translators.translators.glosbe_over_tor_translator import GlosbeOverTorTranslator |
There was a problem hiding this comment.
@joelgrondman - note that many of these removed imports are done automatically by Python when refactoring code since they are not used in the corresponding file.
For SQLAlchemy I have had in the past code which requires a class to be loaded, even if it's not used straight away in that file. I hope this is not the case anywhere here!
| return path_to_cognate_file(primary, secundary, CANDIDATES, method_name) | ||
|
|
||
|
|
||
| def path_of_cognate_blacklist(primary, secundary, author:str = ""): |
There was a problem hiding this comment.
note that many of these changes are also PyCharm reformatting code after a refactoring.
|
Some of the imports we're not correctly handled with pycharm. I've adjusted them and the tests which all pass now. |
|
Thanks for fixing the imports. |
|
ah, kijk! : https://stackoverflow.com/a/21469018/1200070 |
@joelgrondman -- i've used the PyCharm 'refactoring' tool to move several files in their own modules, and split a bigger file in two smaller ones. This makes the code less daunting since there's a bit more structure in the file organization.
Some tests are failing on my machine, but they seem to be failing also on your branch. Can you look into that?