views/tweet: add .author-$user, .retweet-$user to classlist for adblock #718
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to control what content they see or don't in their timelines by exposing author and retweeter information via dedicated CSS classes. Using adblock extensions is at least a little of a cop out, especially considered the changes to extensions that Chrome will soon force on extensions, but it's also the simplest change that will do the trick... at least on desktop. Server-side blocking would require an account system to exist, whereas javascript-side blocking would require javascript to be enabled, something that nitter doesn't give for granted (see also: video playback). Javascript-side blocking would also benefit some kind of change very much like the one I'm making here (the alternative being scraping the DOM this piece of code is generating).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be aware that I literally just installed nim, and that (although this change compiles) I haven't tried actually running this code. I don't even expect this change to be adopted (I don't even use ad-blockers myself), but rather for this to start a conversation on how blocking people on nitter could be implemented (if it should even be supported at all).
The main impetus for this is that I wish to stop being counted as a twitter "daily active user," and yet open links people choose to share with me. Unfortunately, I still lack the mental fortitude not to check out the replies, and regret it immediately afterwards.
Server-side blocking would require an account infrastructure that doesn't exist, or perhaps sending the blocklist as a cookie on every request (at 4,096 chars per cookie, that'd be.... a lot of cookies). Native client-side blocking would require being able to run javascript, something that AFAICT nitter politely asks for in order to enable video playback. This commit relies on the capabilities of existing ad-blocking extensions: just add
.retweet-$userand.author-$userto your blocklist. This mechanism is unsatisfactory in more than one way (mobile, desktop Chrome) but it's 🌈 better than nothing ✨