Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS feeds for threads #409

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

RSS feeds for threads #409

wants to merge 5 commits into from

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Jul 21, 2021

Fixes #343

@duxovni
Copy link
Contributor Author

duxovni commented Jan 9, 2022

Previously, nitter used "does this page not have an RSS feed" as a proxy for "is this page a tweet", in order to decide what type of preview card to use. Now with my changes, user profiles will get the summary_large_image preview card type, causing the user's profile pic to be displayed as a large image in previews. I don't think that's especially a problem, but if people feel strongly that user profile preview cards should only have a thumbnail image, we can work out a better way of distinguishing them.

It'd also be neat to use the player card type for tweets with videos, like robinuniverse/TwitFix does, but extracting an actual mp4 URL from a tweet seems like a messy process that'd definitely want to be a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSS feed for a thread?
1 participant
@duxovni