Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1147, Proxy for audio URL and upgrade hls.js #1148

Closed
wants to merge 2 commits into from
Closed

Fix for #1147, Proxy for audio URL and upgrade hls.js #1148

wants to merge 2 commits into from

Conversation

jackyzy823
Copy link
Contributor

@jackyzy823 jackyzy823 commented Jan 11, 2024 •
edited
Loading

Fix for #1147,

  1. Proxy for audio URL in cmaf container
  2. Upgrade hls.js to 1.5.1 and use full version

Or , we could force using container=fmp4 instead of container=cmaf

@jackyzy823 jackyzy823 changed the title Fix for # 1147, Proxy for audio URL and upgrade hls.js Fix for #1147, Proxy for audio URL and upgrade hls.js Jan 11, 2024
ButteredCats added a commit to ButteredCats/nitter that referenced this pull request Jan 12, 2024
@ButteredCats
Merge zedeus#1148
24bf781
@zedeus
Copy link
Owner

zedeus commented Jan 12, 2024

Thank you for the quick fix, but I'd like to avoid the larger hls.js file and stick with the previous behavior. I've pushed a simple fix to force fmp4.

@zedeus zedeus closed this Jan 12, 2024
@jackyzy823
Copy link
Contributor Author

It's ok for me. Just afraid that twitter might drop fmp4 support in the feature.

ButteredCats added a commit to ButteredCats/nitter that referenced this pull request Jan 15, 2024
@ButteredCats
Revert "Merge zedeus#1148"
3d3bf03 
This reverts commit 24bf781, reversing
changes made to 9634e81.
@jackyzy823
Copy link
Contributor Author

jackyzy823 commented Feb 14, 2024 •
edited
Loading

Just afraid that twitter might drop fmp4 support in the feature.

Sadly, It happened. even using fmp4 in the query , it still returns m3u8 with cmaf format.

But whatever.

ButteredCats added a commit to ButteredCats/nitter that referenced this pull request Feb 15, 2024
@ButteredCats
Merge zedeus#1148 to fix proxied playback
be5a747
@zedeus
Copy link
Owner

zedeus commented Feb 20, 2024

Getting complaints about broken videos, and this supposedly fixes it. Can you reopen and rebase please?

@jackyzy823 jackyzy823 mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyzy823 @zedeus