-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Add file dialog using IFileOpenDialog #8919
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @the-jasoney on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
prompt_for_paths
in windows
Could you include a screenshot of the working file dialog as well? |
I notice that this part of another PR initializes COM for the length of the app, through a different API. Could we use that approach instead? Or is there a compelling reason to keep the approach you're using? |
Once the COM initialization is figured out, and the merge conflicts resolved, I think I'd prefer to merge this one as it looks a little nicer. |
I'm pretty sure the approach in the PR would work. |
@the-jasoney when the merge conflicts are resolved, I'd be down to merge this :) |
The
And since the COM library is initialized on an apartment only once,
Edit: In my previous PR #8809 , actually use |
Now that #8959 has been merged, we should get this branch up to date with main and remove the COM initialization / tear down. Then we can merge :) |
…-industries-main # Conflicts: # .gitignore # Cargo.toml # crates/gpui/src/platform/windows/platform.rs
Seems this needs another merge conflict resolution, and a |
Release Notes: