Add ability to run ESLint (and other non-primary language server) code actions on format #8496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things to fix #4325:
code_actions_on_format
works to send the possibly configured code actions to all (and not just the primary) languages servers. That means configured code actions can now be sent to ESLint, tailwind, ... and other language servers.codeActionsOnSave
by default for ESLint. That does not mean that by default we will run something on save, but only that we enable it for ESLint.Users can then configure their Zed to run the
eslint
code action on format. Example, for JavaScript:Release Notes:
code_actions_on_format
are now being sent to all language servers connected to a buffer, not just the primary one. So if a user now sets"code_actions_on_format": { "source.fixAll.eslint": true }
in their Zed settings, thesource.fixAll.eslint
code action will be sent to ESLint, which is not a primary language server. Since the formatter (prettier, or external commands, or another language server, ...) still runs, it's important that these code actions and the formatter don't clash. (#4325).Demo:
screenshot-2024-02-28-13.31.27.mp4