Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight selections on vim yank #7638

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Highlight selections on vim yank #7638

merged 1 commit into from
Feb 9, 2024

Conversation

ConradIrwin
Copy link
Member

Fixes: #7311

Co-Authored-By: WindSoilder WindSoilder@outlook.com

Release Notes:

  • Added a highlight on yanked text in vim normal mode

or

  • N/A

Fixes: #7311

Co-Authored-By: WindSoilder <WindSoilder@outlook.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 9, 2024
@ConradIrwin ConradIrwin merged commit 3635d2d into main Feb 9, 2024
7 checks passed
@ConradIrwin ConradIrwin deleted the vim-yank-flash branch February 9, 2024 23:18
@mrnugget
Copy link
Member

Neat!

@RustyDev24
Copy link
Contributor

Is there a way to change the highlight timings, or disable the highlighting alltogether ?

@ConradIrwin
Copy link
Member Author

Not yet, but PR's welcome! We could add a setting to the existing vim settings.

What do you want to change about it?

@RustyDev24
Copy link
Contributor

I was thinking of adding a change where we can configure both the highlight timings
so like ppl may want it to flash for only 50ms or smth
and also be able to disable the flashing if they don't want it
also the cursor shape thing doesn't work in insert mode ?

@RustyDev24
Copy link
Contributor

Not yet, but PR's welcome! We could add a setting to the existing vim settings.

What do you want to change about it?

#21479
I made a smol PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vim mode: it's good to flashing yanked selections once, so users can know which lines they yanked.
3 participants