Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localization Crate with i18n standard implementation #7433

Closed
wants to merge 2 commits into from

Conversation

foxkdev
Copy link
Contributor

@foxkdev foxkdev commented Feb 6, 2024

Release Notes:

  • Implementation of Localization ... (#7409 >).

Im implemente crate rust-i18n. https://github.com/longbridgeapp/rust-i18n

Im draft because I want know if this implementation are valid or you prefer other method.

in main.rs I show how translate texts and how set locale.

If all ok Im implement complete method to change locales and translate all texts.

Suggestions and feedback please!

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 6, 2024
@maxdeviant
Copy link
Member

Hey @foxkdev, thanks for your interest in contributing.

I don't think we're at the point where we're ready to start internationalization/localization for Zed.

For big initiatives like this, it would be better to start a GitHub discussion rather than jumping straight into implementation.

I'm going to close this one out for now.

@maxdeviant maxdeviant closed this Feb 6, 2024
@ncs-pl
Copy link

ncs-pl commented Feb 6, 2024

Sorry to intercept, I have started a fresh GitHub discussion on the topic as @maxdeviant encouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants