-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard injection.language and injection.content captures #22268
Merged
maxbrunsfeld
merged 7 commits into
zed-industries:main
from
uncenter:standard-injections-captures
Jan 7, 2025
Merged
Use standard injection.language and injection.content captures #22268
maxbrunsfeld
merged 7 commits into
zed-industries:main
from
uncenter:standard-injections-captures
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Dec 19, 2024
maxbrunsfeld
approved these changes
Jan 7, 2025
Thanks! Sorry for the review delay. Can you resolve the conflicts? I think those extensions were extracted to separate repos. |
uncenter
force-pushed
the
standard-injections-captures
branch
from
January 7, 2025 03:46
0d6e699
to
81491f6
Compare
uncenter
changed the title
Support standard injection.language and injection.content injections captures
Use standard injection.language and injection.content captures
Jan 7, 2025
Going to also update the docs while we are at real quick... |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 7, 2025
Test failure of https://github.com/zed-industries/zed/actions/runs/12645360074/job/35234382353#step:7:2316 |
MrSubidubi
reviewed
Jan 7, 2025
This was referenced Jan 23, 2025
Merged
Merged
notpeter
added a commit
that referenced
this pull request
Jan 23, 2025
notpeter
added a commit
to zed-industries/extensions
that referenced
this pull request
Jan 23, 2025
notpeter
added a commit
that referenced
this pull request
Jan 23, 2025
notpeter
added a commit
to zed-industries/extensions
that referenced
this pull request
Jan 23, 2025
notpeter
added a commit
that referenced
this pull request
Jan 23, 2025
notpeter
added a commit
to zed-industries/extensions
that referenced
this pull request
Jan 23, 2025
Includes: - zed-industries/zed#23532 - zed-industries/zed#22268 Submodule changes for PHP were accidentally included in: - https://github.com/zed-industries/extensions/pull/1946/files
notpeter
added a commit
to zed-industries/extensions
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9656. Continuation of #9654, but with the addition of backwards compatibility for the existing captures.
Release Notes: