Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metal icon #21720

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add metal icon #21720

merged 2 commits into from
Dec 12, 2024

Conversation

nervenes
Copy link
Contributor

@nervenes nervenes commented Dec 8, 2024

Release Notes:

  • Added file icon for metal

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 8, 2024
@nervenes
Copy link
Contributor Author

nervenes commented Dec 8, 2024

Skärmavbild 2024-12-08 kl  23 07 25

@nervenes
Copy link
Contributor Author

nervenes commented Dec 9, 2024

hey @danilo-leal out of curiosity, what software do you use for the svg?

@danilo-leal
Copy link
Contributor

Figma! I redrew the SVG completely to clean it up and ensure it abides to the guidelines we've been using for file icons 🙂

@nervenes
Copy link
Contributor Author

nervenes commented Dec 9, 2024

Nice, thank you! Are the icon guidelines available somewhere I can read? I've had a few more icons in mind, namely Objective-C and C agnostic header file icons.

@mikayla-maki
Copy link
Contributor

Thank you!

@mikayla-maki mikayla-maki merged commit 5787471 into zed-industries:main Dec 12, 2024
12 checks passed
@mikayla-maki
Copy link
Contributor

@nervenes

Are the icon guidelines available somewhere I can read?

Just checked in on this, they are not! We tend to prefer using either Lucide icons or making our own for specific projects. Feel free to open more PRs with placeholders!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants