Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in remove_item #21480

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix panic in remove_item #21480

merged 1 commit into from
Dec 3, 2024

Conversation

ConradIrwin
Copy link
Member

In #20742 we added a call to remove_item that retain an item index over an
await point. This led to a race condition that could panic if another tab was
removed during that time. (cc @mgsloan)

This changes the API to make it harder to misuse.

Release Notes:

  • Fixed a panic when closing tabs containing new unsaved files

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
@ConradIrwin
Copy link
Member Author

/cherry-pick v0.164.x

@ConradIrwin ConradIrwin merged commit b28287c into main Dec 3, 2024
12 checks passed
@ConradIrwin ConradIrwin deleted the remove-item-panic branch December 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant