Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hunk navigation arrow order #21477

Closed

Conversation

Angelk90
Copy link

@Angelk90 Angelk90 commented Dec 3, 2024

Reverse the order of the navigation arrows between the 'hunks'

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
@SomeoneToIgnore
Copy link
Contributor

Notes to someone who wants to review this:

@Angelk90
Copy link
Author

Angelk90 commented Dec 3, 2024

@danilo-leal : What do you think?

@danilo-leal
Copy link
Contributor

Thanks for the PR @Angelk90! I think I'll hold off on pushing this change at the moment. Maybe in the future we can revisit, but even though in spoken language we say "up and down", in this case, it makes sense that the first action is "arrow down" because the next hunk will likely be below the one you're currently at. Appreciate it, though!

@danilo-leal danilo-leal closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants