Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespace from base64 encoded image data before decoding it #19977

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Oct 30, 2024

Closes #17956
Closes #16330

This fix is for both REPL (released) and notebook (unreleased)

image

Release Notes:

  • Fixed image support in REPL for certain versions of matplotlib that included preceding and/or trailing whitespace in the base64 image data

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 30, 2024
@maxdeviant maxdeviant changed the title Trim whitespace from base64 encoded image data before decoding it. Trim whitespace from base64 encoded image data before decoding it Oct 30, 2024
@rgbkrk rgbkrk merged commit 7ce131a into main Oct 30, 2024
12 checks passed
@rgbkrk rgbkrk deleted the trim-whitespace-from-kernel-image-output branch October 30, 2024 19:32
@rgbkrk rgbkrk added the repl repl, jupyter, notebooks, etc label Oct 30, 2024
notpeter pushed a commit that referenced this pull request Oct 31, 2024
…9977)

Closes #17956
Closes #16330

This fix is for both REPL (released) and notebook (unreleased)

<img width="1210" alt="image"
src="https://github.com/user-attachments/assets/bd046f0f-3ad1-4c25-b3cb-114e008c2a69">

Release Notes:

- Fixed image support in REPL for certain versions of matplotlib that
included preceding and/or trailing whitespace in the base64 image data
notpeter pushed a commit that referenced this pull request Oct 31, 2024
…9977)

Closes #17956
Closes #16330

This fix is for both REPL (released) and notebook (unreleased)

<img width="1210" alt="image"
src="https://github.com/user-attachments/assets/bd046f0f-3ad1-4c25-b3cb-114e008c2a69">

Release Notes:

- Fixed image support in REPL for certain versions of matplotlib that
included preceding and/or trailing whitespace in the base64 image data
CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this pull request Nov 18, 2024
…d-industries#19977)

Closes zed-industries#17956
Closes zed-industries#16330

This fix is for both REPL (released) and notebook (unreleased)

<img width="1210" alt="image"
src="https://github.com/user-attachments/assets/bd046f0f-3ad1-4c25-b3cb-114e008c2a69">

Release Notes:

- Fixed image support in REPL for certain versions of matplotlib that
included preceding and/or trailing whitespace in the base64 image data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement repl repl, jupyter, notebooks, etc
Projects
None yet
1 participant