gpui: Fix window display on Windows

[JunkuiZhang]

• Closes Zed Cannot Display a Window on Windows OS after Being Built #18610

This PR addresses the same issue as PR #18578. After a full day of research and testing, I believe I’ve found the best solution to resolve this issue. With this PR, the window creation behavior on Windows becomes more consistent with macOS:

• When params.show is true: The window is created and immediately displayed.
• When params.show is false: The window is created but remains hidden until the first call to activate_window.

As I mentioned in #18578, winit creates hidden windows by setting the window's exstyle to WS_EX_NOACTIVATE | WS_EX_TRANSPARENT | WS_EX_LAYERED | WS_EX_TOOLWINDOW, which is different from the method used in this PR. Here, the window is created with normal parameters, but we do not call ShowWindow so the window is not shown.

I'm not sure why winit doesn't use a smilliar approach like this PR to create hidden windows. My guess is that winit is creating this hidden window to function as a "DispatchWindow" — serving a purpose similar to WindowsPlatform in zed. To ensure the window stays hidden even if ShowWindow is called, they use the exstyle approach.

With the method used in this PR, my initial tests haven't revealed any issues.

Release Notes:

• N/A

[Long0x0]

winit does create windows using the WS_EX_APPWINDOW flag (code here). The window you mentioned is an extra one created for the event loop that is never visible.

[evaneaston]

I've verified that this fixes the reported problem. I have no idea if it's the correct way to solved it.

[co-bby]

Tested is working

[MarvinMynx]

I had the same issue "no Window after Build Process" can confirm that this fix works too.

[AFellowSpeedrunner]

Added it into my source tree, can also confirm it works on Windows 11 Home 23H2.

Thanks for the patch by the way, spent forever trying to figure this out myself...

EDIT: I forgot to mention, but I've been using this for over a day and I myself haven't found any issues with this change yet.

[zhouxs1023]

still turn on error as below:
Error { kind: Generic("Input watch path is neither a file nor a directory."), paths: [] }

[shenjackyuanjie]

still turn on error as below: Error { kind: Generic("Input watch path is neither a file nor a directory."), paths: [] }

this error is not related to this issue

[AFellowSpeedrunner]

Any timeframe for when this gets merged?

[SomeoneToIgnore]

I have no clue about these changes, but given the previous change got merged and this is tested by others and reported to be fixing the issue, let's merge this and @mikayla-maki can post-review if needed.

Odd that I have never experienced that in my Windows builds.

[getpool]

最近更新编译，在windows下，没办法保存正确的窗口大小，没办法最大化，删除db，也是一样。
我只能手动修改db.sqlite,把window_with和window_height改成我的显示尺寸大小。

大佬能不能增加个兼容一下，老旧设备不支持vulkan的问题呢。

[JunkuiZhang]

最近更新编译，在windows下，没办法保存正确的窗口大小，没办法最大化，删除db，也是一样。 我只能手动修改db.sqlite,把window_with和window_height改成我的显示尺寸大小。

I will open a PR to address this tomorrow.

大佬能不能增加个兼容一下，老旧设备不支持vulkan的问题呢。

The only possible solution is porting the backend from blade to directX, but zed team rejected my PR of porting to directX. So, I can’t, sorry.