Tweak git blame tooltip design #17517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tiny design tweaks to the git blame tooltip. I guess the most "notable", so to speak, thing is the addition of a divider between the pull request and commit hash buttons. I was motivated to do that because, at first, I was unsure what the copy button would copy (the PR number or the hash?). From the position only, you eventually figure out, but hopefully, the divider will help bumping this affordance a bit more. I experimented with adding a labeled "Copy commit hash" button, but that'd clutter the design too much. Additionally, the top border on the footer should also slightly help indicating the commit message area is scrollable.
Release Notes: