-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve completions for TypeScript #10787
Conversation
The new labels look great. Could you explain a bit more about why the separate |
It's not completely necessary. You could definitely determine in the label function which kind of completion you're dealing with, but for the TS LSP (and maybe for others) the format is completely different depending on whether they are regular completions or resolved completions. I figured it was easier to do it this way and maybe there are some other LSPs where it's not so easy to differentiate. |
|
Without having looked too closely at the code: @babyccino it might be worth checking against |
Hi @mikayla-maki, I'm curious what the status of this is? Is it ready to be merged? |
I got distracted by #12106 so I haven't worked on this in a while. It's still in a very rough state and definitely not ready to be merged. If Zed is still interested in this I can work on it after #12106 is merged |
@babyccino I'm going to close for now, but please re-open when you get time to work on it! |
Related to #5287
This is a WIP but I just wanted to check if this is something Zed would be interested in before I put more time into it. Basically what I've done is changed the LSP functionality so labels as well as documentation is updated from the LSP
completionItem/resolve
response.Before:
After: