-
Notifications
You must be signed in to change notification settings - Fork 13
Fix launching phpactor.phar on windows #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'm encountering an issue where Inteliphense isn't functioning. This leads me to wonder if the recently added sanitization is fully effective, especially concerning path handling on Windows. |
There is currently no merged code. |
Thanks for the ping and sorry for the slow response from our side - I already took a look, but had to get my Windows machine up and running. Looks good overall, I'll push some minor polish before merging most likely. Will take another look over the next few days, currently recovering from an illness but will be one of the first things after I am back. In any case, thanks for taking the time to write this up! |
thank u. I hope you are healthy. |
I am better now, thank you. Got it ready locally, could you please allow me to edit the PR? I'd like to make some final changes, check back with you and then merge it this week! |
You can look at the changes I made here: https://github.com/zed-extensions/php/tree/final-changes I have these already ready to push on your branch, so if that works for you and once I have write-access, happy to merge this finally. Sorry for the long wait! |
Uh oh!
There was an error while loading. Please reload this page.