Skip to content

Conversation

imblowsnow
Copy link

@imblowsnow imblowsnow commented Apr 26, 2025

This comment was marked as resolved.

@imblowsnow

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed label Apr 26, 2025

This comment was marked as resolved.

@notpeter notpeter changed the title fix: https://github.com/zed-extensions/php/issues/23 Fix launching phpactor.phar on windows Apr 26, 2025
@dnieblesdev
Copy link

I'm encountering an issue where Inteliphense isn't functioning. This leads me to wonder if the recently added sanitization is fully effective, especially concerning path handling on Windows.

@imblowsnow
Copy link
Author

I'm encountering an issue where Inteliphense isn't functioning. This leads me to wonder if the recently added sanitization is fully effective, especially concerning path handling on Windows.

There is currently no merged code.

@imblowsnow
Copy link
Author

@MrSubidubi

@MrSubidubi
Copy link
Contributor

MrSubidubi commented Sep 25, 2025

Thanks for the ping and sorry for the slow response from our side - I already took a look, but had to get my Windows machine up and running. Looks good overall, I'll push some minor polish before merging most likely.

Will take another look over the next few days, currently recovering from an illness but will be one of the first things after I am back.

In any case, thanks for taking the time to write this up!

@imblowsnow
Copy link
Author

Thanks for the ping and sorry for the slow response from our side - I already took a look, but had to get my Windows machine up and running. Looks good overall, I'll push some minor polish before merging most likely.

Will take another look over the next few days, currently recovering from an illness but will be one of the first things after I am back.

In any case, thanks for taking the time to write this up!

thank u. I hope you are healthy.

@MrSubidubi
Copy link
Contributor

I am better now, thank you.

Got it ready locally, could you please allow me to edit the PR? I'd like to make some final changes, check back with you and then merge it this week!

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@MrSubidubi
Copy link
Contributor

You can look at the changes I made here: https://github.com/zed-extensions/php/tree/final-changes

I have these already ready to push on your branch, so if that works for you and once I have write-access, happy to merge this finally. Sorry for the long wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phpactor does not work under Windows because .phar files are not executable
3 participants