Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make install doesn't update icon cache #922

Closed
marcelpaulo opened this issue Apr 8, 2018 · 5 comments
Closed

make install doesn't update icon cache #922

marcelpaulo opened this issue Apr 8, 2018 · 5 comments
Assignees
@trollixx
Labels
platform/linux scope/build-system status/done type/enhancement
Milestone
0.6.1

Comments

@marcelpaulo
Copy link

marcelpaulo commented Apr 8, 2018 •
edited by trollixx
Loading

I've just built zeal from source (30c85bb) on Xubuntu 17.10, using the default prefix (/usr/local), and the icon cache is not updated. After running make install, I updated the cache running:

sudo gtk-update-icon-cache -f -t /usr/local/share/icons/hicolor

I imagine the cmake config files should be ammended to include that.
@trollixx
Copy link
Member

trollixx commented Apr 8, 2018

We should use ECMInstallIcons.

@trollixx trollixx added this to the 0.6.1 milestone Apr 8, 2018
@trollixx trollixx self-assigned this Apr 8, 2018
@trollixx
Copy link
Member

trollixx commented Apr 15, 2018 •
edited
Loading

ECM supports icon cache updates since v5.15.0 (commit, review).

trollixx added a commit to trollixx/zeal that referenced this issue Apr 15, 2018
@trollixx
assets: Install app icons with ECMInstallIcons (fixes zealdocs#922)
2906d2e
@marcelpaulo
Copy link
Author

Indeed, the icon cache is being updated now. Removed /usr/local/share/icons/hicolor/icon-theme.cache, rebuilt/reinstalled zeal, and the icon cache was regenerated. Thanks !

@trollixx
Copy link
Member

@marcelpaulo Thanks for verifying the fix! I'll release v0.6.1 shortly.

@lock
Copy link

lock bot commented Mar 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trollixx trollixx

Labels
platform/linux scope/build-system status/done type/enhancement
Milestone
0.6.1
Development

No branches or pull requests
2 participants
@trollixx @marcelpaulo