Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor exact search match over substring ones #613

Closed
aomader opened this issue Oct 7, 2016 · 3 comments
Closed

Favor exact search match over substring ones #613

aomader opened this issue Oct 7, 2016 · 3 comments
Labels
scope/docset-registry status/duplicate Duplicate of another issue. type/defect

Comments

@aomader
Copy link

aomader commented Oct 7, 2016

For example, try to search for the built-in function len in python. The word is so common, that Zeal shows a lot of noise before the actually matching function:
image

A very trivial fix would ensure that exactly matching search strings are favored. However, a potentially more improved approach would rate each search hit and show the hits according to their rating. An exact search hit should get a higher rating in this case. That should play nicely with fuzzy searching.
@jkozera
Copy link
Member

jkozera commented Oct 7, 2016 •
edited
Loading

Shameless plug for my sqlite match scoring implementation which could be potentially reused here: https://github.com/zestdocs/zest/blob/master/sqlite_score/score.c#L87 (ported from devdocs - https://github.com/Thibaut/devdocs/blob/50f583246d5fbd92be7b71a50bfa56cf4e239c14/assets/javascripts/app/searcher.coffee#L91)

(EDIT: grammar)
(EDIT2: screenshot, PR coming soon :D)

Right, so I couldn't resist and implemented it.

screenshot from 2016-10-07 15-28-12

jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
38c9d17 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
965ba42 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
581d1da 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
af18b1d 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
452d6b1 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
1897f22 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
2cfeb37 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
79ff445 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 7, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
f28ad96 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
@trollixx
Copy link
Member

trollixx commented Oct 8, 2016

It's actually a duplicate of #603.

@trollixx trollixx closed this as completed Oct 8, 2016
jkozera added a commit that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (#613, #100)
df47804 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR #281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
8a1862c 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
245eab1 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
6580cf7 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
afa7cd2 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 8, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
acea11a 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
f001b4b 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
47f62ab 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
f35c216 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
8d5570d 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
d239c15 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
78ced7b 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 9, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
7e0efb9 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 21, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
29baef1 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 21, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
19ea667 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
jkozera added a commit to jkozera/zeal that referenced this issue Oct 27, 2016
@jkozera
Better sorting of search results (zealdocs#613, zealdocs#100)
40d626d 
Uses an O(m+n) algorithm based on https://github.com/bevacqua/fuzzysearch
- should be faster than the one initially proposed in PR zealdocs#281.
@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related requests.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope/docset-registry status/duplicate Duplicate of another issue. type/defect
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aomader @jkozera @trollixx