Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust docset not completely rendered ("Loading content...") #1195

Closed
cyphar opened this issue Feb 26, 2020 · 7 comments · Fixed by #1125
Closed

Rust docset not completely rendered ("Loading content...") #1195

cyphar opened this issue Feb 26, 2020 · 7 comments · Fixed by #1125

Comments

@cyphar
Copy link

cyphar commented Feb 26, 2020

If you try to load the documentation for std::iter::Iterator, the documentation has been stripped of its JavaScript and the method documentation is missing entirely (all that is there is a Loading content... placeholder). I think this is because Rust's documentation uses JavaScript to fill in the documentation section for some trait and struct methods.

Zeal Screenshot -- Iterator

2020-02-26-203312_1426x339_scrot

docs.rust-lang.org Screenshot -- Iterator

2020-02-26-203332_990x453_scrot
2020-02-26-203257_1026x563_scrot

This happens for more than just Iterator, the same issue is present for std::option::Option:

Zeal Screenshot -- Option

2020-02-26-203858_572x759_scrot

docs.rust-lang.org Screenshot -- Option

2020-02-26-203845_993x669_scrot

... and any other Rust stdlib types I've tried to look up (such as std::vec::Vec). I'm not sure if this is a problem with the Rust docset itself or if it's how Zeal renders it, but it renders the offline documentation practically useless because you can't get any documentation about methods on stdlib types and traits.

@condy0919
Copy link

Same issue after updating docsets

@trollixx
Copy link
Member

I don't think it's an issue with Zeal though, same problem occurs in Chrome and Firefox when loading the page. No errors in the console.

@cyphar

This comment has been minimized.

@trollixx
Copy link
Member

I was talking about pages from the docset. You can open them in an external browser, there's an option in the context menu.

@cyphar
Copy link
Author

cyphar commented Mar 16, 2020

Ah okay. However I did just try that, and it does render the methods of std::option::Option (though they are rendered quite differently to https://docs.rust-lang.org/ -- but I guess that's just how the source docsets are rendered).

from context menu

@ruffson
Copy link

ruffson commented Apr 19, 2020

Not sure if this is related, but I also noticed that some entries (or many actually) are incomplete. I just updated the Rust docs again and checked e.g. std::collections::HashMap.

Here is what zeal shows me:

zeal_hashmap

And here is what the official docs show (I had to collapse the methods to show more than the first few. Although still could not fit all.):

firefox_hashmap

Sadly this makes Zeal quite useless for Rust right now.

@trollixx trollixx linked a pull request Apr 26, 2020 that will close this issue
@trollixx
Copy link
Member

Using Qt WebEngine (#1125) appears to fix the rendering.

@trollixx trollixx added this to the 0.7.0 milestone Apr 26, 2020
@ruffson ruffson mentioned this issue Jan 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

4 participants