Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document import! #318

Closed
indigoviolet opened this issue Sep 22, 2016 · 5 comments
Closed

document import! #318

indigoviolet opened this issue Sep 22, 2016 · 5 comments
Labels

Comments

@indigoviolet
Copy link
Contributor

Seems like a useful method, but isn't mentioned anywhere (at least I didn't find it)

@jkowens jkowens added the docs label Oct 6, 2016
@jkowens
Copy link
Collaborator

jkowens commented Oct 6, 2016

You're right, this should be added to the wiki!

@jkowens jkowens mentioned this issue Apr 4, 2017
10 tasks
@soundasleep
Copy link

I added a quick note to https://github.com/zdennis/activerecord-import/wiki with it :)

@dillonwelch
Copy link
Contributor

It looks like this is pretty heavily documented in the code and in the RubyDoc code wiki. I'm not sure that anything more needs to be done here?

https://github.com/zdennis/activerecord-import/blob/master/lib/activerecord-import/import.rb
https://www.rubydoc.info/gems/activerecord-import/ActiveRecord%2FBase.bulk_import

@dillonwelch
Copy link
Contributor

Thoughts @jkowens ?

@jkowens
Copy link
Collaborator

jkowens commented Nov 15, 2018

I'm thinking it might be nice to create a table of options similar to the way it was done for active_admin_import. When describing the :raise_error option it could be mentioned that the bang method is a shortcut for including that option.

dillonwelch added a commit to dillonwelch/activerecord-import that referenced this issue Nov 29, 2018
dillonwelch added a commit to dillonwelch/activerecord-import that referenced this issue Nov 29, 2018
dillonwelch added a commit to dillonwelch/activerecord-import that referenced this issue Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants