Address comments from zcash/zips#989 #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org> Co-authored-by: Josh Swihart <josh@electriccoin.co>
daira
reviewed
Apr 1, 2025
| @@ -84,21 +86,20 @@ This funding stream will start on expiry of the existing ``FS_FPF_ZCG`` funding | |||
|
|
|||
There was a problem hiding this comment.
Clarify (e.g. on line 77) that grant applications may be made to ZCG, the Coinholder-Controlled Fund, or (if desired) both. Also say what happens if redundant or conflicting proposals are concurrently accepted by ZCG and the Coinholder-Controlled Fund.
daira
reviewed
Apr 1, 2025
| 5. If the vote passes, then as payments are scheduled for the grant, then (subject to the [Veto process]) the Key-Holder Organizations SHOULD sign the corresponding transactions for disbursement from the Coinholder-Controlled Fund. | ||
| 2. Coinholders will vote on grant applications every three months. Grant applications must be submitted for community review 30 days prior to coinholder voting. | ||
| 3. If a grant application is not [vetoed](#veto-process) and proceeds to a coinholder vote according to the agreed process, then coinholders will be asked to vote on it. | ||
| 4. If the vote passes, then as payments are scheduled for the grant, then (subject to the [Veto process]) the Key-Holder Organizations SHOULD sign the corresponding transactions for disbursement from the Coinholder-Controlled Fund. | ||
|
|
||
| For coinholder votes, a minimum of 420,000 ZEC (2% of the total eventual supply) MUST be voted, with a simple majority cast in favor, for a grant proposal to be approved. Upon approval, the grants are paid to the recipient per the terms of the grant proposal. In the case that multiple grant proposals are submitted that are in competition with one another, a single winner will be selected by holding a separate coinholder vote for each proposal, with the approved proposal having the highest total ZEC value committed in support being the winner. It is the responsibility of the Key-Holder Organizations to determine whether proposals are in competition with one another when organizing coinholder votes. |
There was a problem hiding this comment.
This doesn't cover the case where redundant or competing proposals are submitted concurrently to ZCG and the Coinholder-Controlled Fund.
daira
reviewed
Apr 1, 2025
| @@ -188,7 +188,7 @@ In cases where the zBloc governance processes could not be used for this reason, | |||
|
|
|||
| A pool of multisig-controlled funds, seeded from the existing contents of the ZIP 1015 Deferred Dev Fund Lockbox [^zip-1015-lockbox] and supplemented with a funding stream consising of 20% of the block subsidy starting at block 3146400 that will continue until modified by a future ZIP, forms a new Zcash Community Fund. The mechanisms for the creation and management of this fund are described by the Deferred Dev Fund Lockbox Disbursement proposal [^draft-ecc-lockbox-disbursement], with the $\mathsf{stream\_value}$ parameter set to 20%, and the $\mathsf{stream\_end\_height}$ parameter set to the height at which the Zcash block subsidy diminishes to zero. | |||
|
|
|||
| The Zcash Community Fund will be controlled by a multisig with keys held by the Financial Privacy Foundation, the Zcash Foundation and the Electric Coin Company, along with two other entities yet to be determined ("Key-Holder Organisations"). | |||
| The Zcash Community Fund will be controlled by a multisig with keys held by the Zcash Foundation and the Electric Coin Company, along with three other entities yet to be determined ("Key-Holder Organisations"). | |||
There was a problem hiding this comment.
To be clear, is it intended that this ZIP ends the current arrangement for management of the Dev Fund by FPF specified in ZIP 1015? If it does, then this is inconsistent with at least line 224 below.
daira
reviewed
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.