Fix GetMempoolTx bug returning no entries #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryRuane
force-pushed
the
2022-07-GetMempoolTx-no-entries
branch
from
d2b83d7
to
8f89fc0
Compare
|
Force-pushed to eliminate some |
This was broken by PR 393, which changed how txids are determined.
LarryRuane
force-pushed
the
2022-07-GetMempoolTx-no-entries
branch
from
8f89fc0
to
cc9f922
Compare
|
Force-pushed a small code simplification (no functional effect). |
LarryRuane
commented
Jul 21, 2022
| @@ -466,6 +466,11 @@ func (s *lwdStreamer) GetMempoolTx(exclude *walletrpc.Exclude, resp walletrpc.Co | |||
| } | |||
| newmempoolMap[txidstr] = &walletrpc.CompactTx{} | |||
| if tx.HasShieldedElements() { | |||
| txidBytes, err := hex.DecodeString(txidstr) | |||
There was a problem hiding this comment.
In a future PR, we could make newmempoolMap more space-efficient by changing its key type to slice of bytes, rather than string. Then we wouldn't have to decode back to bytes here (but we would have to encode to string elsewhere). It's not too bad as it currently is, however, because the mempool typically doesn't have many entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by PR #393, which changed how txids are determined. After
GetMempoolTxfetches individual transactions, they're converted to compact format, one attribute of which is transaction ID (txid), and that wasn't being filled in. This prevented any entries from being returned (see test atlightwalletd/frontend/service.go
Line 480 in db2795a
Note that this gRPC is probably not being widely used; the ECC wallets use the more recent (and arguably superior)
GetMempoolStream.