Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm Dashboard Connection #250

Merged
merged 17 commits into from
Jan 16, 2025
Merged

Swarm Dashboard Connection #250

merged 17 commits into from
Jan 16, 2025

Conversation

LukasBaecker
Copy link
Contributor

For handling a robot swarm, we are developing a robot dashboard. Robots that have saved a dashboard address in their .env file regularly send their status to this address.

@LukasBaecker LukasBaecker added this to the 0.8.0 milestone Jan 2, 2025
@pascalzauberzeug pascalzauberzeug added the enhancement New feature or request label Jan 6, 2025
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed everything dashboard related to swarm.
I don't like the big try-block in the swarm update, but I think it's okay for now

@LukasBaecker
Copy link
Contributor Author

To drive the process forward, we will merge the changes as they are. In the future, we want to move the swarm connection to its own class as in this commit we had in between.

@LukasBaecker
Copy link
Contributor Author

The code was tested on multiple robots and had no issues.

@pascalzauberzeug pascalzauberzeug marked this pull request as ready for review January 16, 2025 14:15
@pascalzauberzeug pascalzauberzeug self-requested a review January 16, 2025 14:18
Copy link
Contributor

@pascalzauberzeug pascalzauberzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to remove the try block completely, will merge now

@pascalzauberzeug pascalzauberzeug changed the title Dashboard Connection Swarm Dashboard Connection Jan 16, 2025
@pascalzauberzeug pascalzauberzeug merged commit 9a1b68b into main Jan 16, 2025
2 checks passed
@pascalzauberzeug pascalzauberzeug deleted the dashboard_connection branch January 16, 2025 14:18
LukasBaecker added a commit that referenced this pull request Jan 16, 2025
In #250 we missed to
convert the geo coordinates from radians to degrees

---------

Co-authored-by: Lukas Baecker <baecker.lukas@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants