Extract encryption module #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| group = OpenSSL::PKey::EC::Group.new(group_name) | ||
| client_public_key_bn = OpenSSL::BN.new(Base64.urlsafe_decode64(p256dh), 2) | ||
| client_public_key = OpenSSL::PKey::EC::Point.new(group, client_public_key_bn) |
There was a problem hiding this comment.
Creation of the client_public_key was simplified by using Base64.urlsafe_decode64(p256dh), 2 to construct the the OpenSSL::BN object.
Add ece as development dependency Update gemspec
Includes spec against third party implementation of the http encrypted content encoding - the ece gem
rossta
force-pushed
the
extract_encryption_module
branch
from
1ef7131
to
20dfb09
Compare
| [key.to_s(16)].pack("H*") | ||
| end | ||
|
|
||
| def unescape_base64(base64) |
There was a problem hiding this comment.
This method was removed in the new module. It's no longer needed since the client keys are decoded with Base64.urlsafe_decode64
|
@rossta |
|
@zaru Great! Thanks for the quick review, merge, and new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the encryption functionality. The methods specific to encrypting the payload including
#encrypthave been extracted to a new moduleWebpush::Encryption(separation of concerns, testing, etc).