Don't include API key for firefox or other browsers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox will fail with a 400 Bad Request if the api key header is included. Instead of having the user have to figure out themselves whether a particular subscription is a Chrome or Firefox subscription, lets do it for them here.
|
Makes sense. I think it would be useful to provide a test case for this behavior. |
|
Sure, I've fixed the failing test and added a new one to test this behavior |
|
merged, thank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox will fail with a 400 Bad Request if the api key header is included. Instead of having the user have to figure out themselves whether a particular subscription is a Chrome or Firefox subscription, lets do it for them here.