Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the response more detailed. #10

Merged
merged 1 commit into from
May 23, 2016
Merged

Make the response more detailed. #10

merged 1 commit into from
May 23, 2016

Conversation

kevinjom
Copy link

  1. Update request#perform to let it return the raw http response, or raise an
    exception when unexpected error happened.
  2. Update the webpush_spec to make the tests pass.

Make the response more detailed.
686935e 
1. Update `request#perform` to let it return the raw http response, or raise an
exception when unexpected error happened.
2. Update the `webpush_spec` to make the tests pass.
@kevinjom kevinjom mentioned this pull request May 20, 2016
Closed
@zaru
Copy link
Owner

zaru commented May 23, 2016

thanks for PR.
It looks good is certainly better to throw an exception.

@zaru zaru merged commit f4ac5ac into zaru:master May 23, 2016
@kevinjom kevinjom deleted the detail-response branch August 29, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinjom @zaru