Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds documentation for sharding and sharding in Array.info #2644

Merged
merged 8 commits into from
Jan 5, 2025
Merged

Adds documentation for sharding and sharding in Array.info #2644

merged 8 commits into from
Jan 5, 2025

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 4, 2025

@normanrz normanrz added this to the 3.0.0 milestone Jan 4, 2025
@normanrz normanrz requested a review from jhamman January 4, 2025 13:23
@normanrz normanrz self-assigned this Jan 4, 2025
@normanrz normanrz added the documentation Improvements to the documentation label Jan 4, 2025
@normanrz normanrz requested a review from dstansby January 4, 2025 13:41
dstansby
dstansby approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions. I wasn't too confident reviewing the code, so would be worth a second check of those bits by someone else.

normanrz and others added 2 commits January 4, 2025 17:30
@normanrz @dstansby
Apply suggestions from code review
e96be80 
Co-authored-by: David Stansby <dstansby@gmail.com>
@normanrz
pr feedback
a8809b7
jhamman
jhamman approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @normanrz - much better than I would have done :)

@normanrz normanrz enabled auto-merge (squash) January 5, 2025 07:29
@normanrz normanrz merged commit df18805 into main Jan 5, 2025
33 checks passed
@dstansby dstansby deleted the docs/sharding branch January 5, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@dstansby dstansby dstansby approved these changes

Assignees

@normanrz normanrz

Labels
documentation Improvements to the documentation
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Array.info should print shard sizes
3 participants
@normanrz @jhamman @dstansby