Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with zarr 3 beta #597

Merged

Conversation

mpiannucci
Copy link

This syncs the zarr3 wrapper with the latest zarr beta.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@jhamman jhamman requested a review from normanrz October 15, 2024 20:05
@jhamman
Copy link
Member

jhamman commented Oct 15, 2024

@normanrz - we (@mpiannucci and the crew at Earthmover) are interested in helping finish off #524. Do you have the bandwidth to review some work in this space?

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (b75e41e) to head (d01669b).
Report is 1 commits behind head on zarr3-codecs.

Files with missing lines Patch % Lines
numcodecs/zarr3.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           zarr3-codecs     #597      +/-   ##
================================================
- Coverage         94.31%   91.29%   -3.02%     
================================================
  Files                61       61              
  Lines              2584     2586       +2     
================================================
- Hits               2437     2361      -76     
- Misses              147      225      +78     
Files with missing lines Coverage Δ
numcodecs/zarr3.py 57.71% <50.00%> (+0.48%) ⬆️

... and 3 files with indirect coverage changes

@normanrz normanrz merged commit a4cf7ad into zarr-developers:zarr3-codecs Oct 16, 2024
18 of 24 checks passed
@mpiannucci mpiannucci deleted the zarr3-codecs-beta-sync branch October 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants